Add jquery as depenendency for tributejs #3018
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Julius Härtl <[email protected]>
This was referenced Aug 12, 2022
juliusknorr
requested review from
a team,
PVince81,
artonge,
raimund-schluessler and
skjnldsv
and removed request for
a team
ChristophWurst
approved these changes
Aug 12, 2022
Pytal
approved these changes
Aug 12, 2022
Contributor
|
@juliushaertl could you please elaborate why this is necessary / helps? Tributejs has literally no dependencies. |
Contributor
Author
|
@raimund-schluessler You're right, actually the issue is not triggered by tribute.js or nextcloud-vue but the web pack provide plugin that the server uses. https://github.com/nextcloud/server/blob/master/webpack.common.js#L144 This causes the following tribute.js code to fail then as it tires to resolve it from the linked path: I'll see if there is a way to fix this in the server webpack config. |
Contributor
Author
|
Found a way nextcloud/server@d78b82b |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds jquery to the vue library as a dependency, to avoid issues during npm link with other repos, which shouldn't matter in terms of building as those are marked as external anyways.
Required for nextcloud/server#33517